[CI validation – do not merge] PR 930 (TMGimporter Windows skip) on maintenance/gramps61#37
Closed
eduralph wants to merge 1 commit into
Closed
[CI validation – do not merge] PR 930 (TMGimporter Windows skip) on maintenance/gramps61#37eduralph wants to merge 1 commit into
eduralph wants to merge 1 commit into
Conversation
The import tests drive a real in-memory Gramps database (make_database + db.load) through the shared _make_db() helper. On the Windows CI lane the only available Gramps is from conda-forge, which has no 6.1 yet, and Gramps 6.1 does not build in the conda env (its Windows build targets MSYS2 UCRT64, not conda). Run against that mismatched Gramps the real-DB import path hangs. Raise unittest.SkipTest from _make_db() on win32 so all 13 DB-backed test classes skip in one place; the pure-function tests (code stripping, date conversion, name parsing) do not call _make_db() and continue to run on Windows. On Linux every test runs unchanged (157 pass). Verified the Windows path with sys.platform forced to win32: 95 tests skip, 62 run and pass, the module is not all-skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
eduralph
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway validation answering: does CI run clean after merging PR 930?
This is PR 930's commit (TMGimporter real-DB import tests skipped on Windows) cherry-picked onto the fork's
maintenance/gramps61, which already carries the CI pipeline. So the fork's Actions run the actual post-merge CI — watch Unit Tests (Windows) (930's target) and Unit Tests (Linux) for regression.Note: gramps61's pipeline snapshot is slightly behind
feature/ci-cd-pipeline-upstream(PR 820), but 930 is a self-contained test-skip, independent of pipeline changes.DO NOT MERGE.